-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support basic dependencies #1622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
commit 055aeca Author: Jan Mas Rovira <janmasrovira@gmail.com> Date: Wed Nov 30 15:46:40 2022 +0100 change export to avoid conflicts commit 98043d0 Author: Jan Mas Rovira <janmasrovira@gmail.com> Date: Tue Nov 29 16:45:58 2022 +0100 add recursor for pure implementation commit df84249 Author: Jan Mas Rovira <janmasrovira@gmail.com> Date: Mon Nov 28 21:58:39 2022 +0100 refactor Files commit 3fbf9a3 Author: Paul Cadman <git@paulcadman.dev> Date: Wed Nov 30 14:58:01 2022 +0000 Use the same stack version in all CI jobs and remove `stack setup` step (#1651) * Remove `stack setup` step as this was only required for macOS * Use haskell setup action so same version of stack is used in tests and build
commit ca41030 Author: janmasrovira <janmasrovira@gmail.com> Date: Wed Nov 30 18:38:06 2022 +0100 Files pure refactor (#1652) commit 57a6a7e Author: Łukasz Czajka <62751+lukaszcz@users.noreply.github.com> Date: Wed Nov 30 16:26:44 2022 +0100 Fix 'not a primitive type' error message (#1648) commit 3fbf9a3 Author: Paul Cadman <git@paulcadman.dev> Date: Wed Nov 30 14:58:01 2022 +0000 Use the same stack version in all CI jobs and remove `stack setup` step (#1651) * Remove `stack setup` step as this was only required for macOS * Use haskell setup action so same version of stack is used in tests and build
commit f5de5fa Author: Łukasz Czajka <62751+lukaszcz@users.noreply.github.com> Date: Tue Dec 6 11:33:20 2022 +0100 Translation from JuvixAsm to C (#1619) commit fb2723c Author: Jonathan Cubides <jonathan.cubides@uib.no> Date: Mon Dec 5 11:20:00 2022 +0100 Update Changelog v0.2.7 🎉 commit 6534287 Author: Jonathan Cubides <jonathan.cubides@uib.no> Date: Mon Dec 5 10:28:35 2022 +0100 Ignore binary files from examples commit 2db738a Author: janmasrovira <janmasrovira@gmail.com> Date: Fri Dec 2 10:04:56 2022 +0100 Upgrade stack snapshot to use ghc-9.2.5 (#1621) * upgrade stack snapshot to use ghc-9.2.5 * use lts-20.2 * Update alpine GHC Dockerfile to 9.2.5 We also build the Juvix runtime before the stack build in the linux-static-binary workflow file. * Add some documentation on how to build and deploy the alpine GHC image * Docker documentation clarification. Co-authored-by: Paul Cadman <git@paulcadman.dev> commit ca41030 Author: janmasrovira <janmasrovira@gmail.com> Date: Wed Nov 30 18:38:06 2022 +0100 Files pure refactor (#1652) commit 57a6a7e Author: Łukasz Czajka <62751+lukaszcz@users.noreply.github.com> Date: Wed Nov 30 16:26:44 2022 +0100 Fix 'not a primitive type' error message (#1648) commit 3fbf9a3 Author: Paul Cadman <git@paulcadman.dev> Date: Wed Nov 30 14:58:01 2022 +0000 Use the same stack version in all CI jobs and remove `stack setup` step (#1651) * Remove `stack setup` step as this was only required for macOS * Use haskell setup action so same version of stack is used in tests and build
paulcadman
reviewed
Dec 16, 2022
paulcadman
reviewed
Dec 16, 2022
paulcadman
reviewed
Dec 16, 2022
paulcadman
reviewed
Dec 16, 2022
This is now required at the root of the `juvix-stdlib` directory for cabal-install as now the stdlib is processed as a Juvix package
paulcadman
reviewed
Dec 16, 2022
paulcadman
reviewed
Dec 16, 2022
paulcadman
reviewed
Dec 16, 2022
* nat to int wip * nat to int wip * fix condition * nats in core * bugfixes * tests * make ormolu happy * fix case
paulcadman
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr has two goals:
FilePath
to usePath
.In order to specify the list of dependencies for a package, the field
dependencies
has been added to thejuvix.yaml
.The
dependencies
field is a list of directories (relative or absolute) that must point to other directories that also contain ajuvix.yaml
.As expected, if we add a package to the list of dependencies, we will be able to access its modules through import statements.
Regarding the standard library, the behaviour is as follows:
dependencies
field is omitted, thestdlib
is copied under.juvix-build/stdlib
.dependencies
field is not omitted and contains the directory.juvix-build/stdlib
, it is also copied.stdlib
is not copied.We have discussed some alternatives that are much better than the current behaviour, but we agreed to change that in a separate pr.