Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String builtins #1784

Merged
merged 7 commits into from
Jan 31, 2023
Merged

String builtins #1784

merged 7 commits into from
Jan 31, 2023

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Jan 30, 2023 •
edited by jonaprieto
Loading

  • Adds builtin primitives for operations on strings and removes the corresponding foreign & compile blocks.

@lukaszcz lukaszcz added enhancement New feature or request language labels Jan 30, 2023
@lukaszcz lukaszcz added this to the 0.3 - Valencia milestone Jan 30, 2023
@lukaszcz lukaszcz self-assigned this Jan 30, 2023
@lukaszcz lukaszcz force-pushed the string-builtins branch 2 times, most recently from f2bc158 to 0d8ebbf Compare January 31, 2023 10:02
@lukaszcz lukaszcz marked this pull request as ready for review January 31, 2023 10:30
janmasrovira
janmasrovira reviewed Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@janmasrovira janmasrovira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lot of C format changes unrelated to the pr. Could we separate those in another pr?

@lukaszcz
Copy link
Collaborator Author

There seems to be a lot of C format changes unrelated to the pr. Could we separate those in another pr?

Okay, but we'll be removing the old C runtime code anyway (that's where the reformatting is, because I have "format on save" in VSCode).

janmasrovira
janmasrovira reviewed Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@janmasrovira janmasrovira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@lukaszcz lukaszcz requested a review from janmasrovira January 31, 2023 16:03
janmasrovira
janmasrovira reviewed Jan 31, 2023
View reviewed changes
@lukaszcz lukaszcz requested a review from janmasrovira January 31, 2023 16:47
@jonaprieto jonaprieto merged commit 4be4d58 into main Jan 31, 2023
@jonaprieto jonaprieto deleted the string-builtins branch January 31, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira janmasrovira approved these changes

Assignees

@lukaszcz lukaszcz

Labels
enhancement New feature or request language
Projects
None yet
Milestone
0.3 - Valencia
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszcz @janmasrovira @jonaprieto