Per-module compilation #2468
Merged
Per-module compilation #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
added
enhancement
lukaszcz
force-pushed
the
per-module-compilation
branch
3 times, most recently
from
f60a0c4 to
bee4360
Compare
lukaszcz
force-pushed
the
per-module-compilation
branch
from
fd74b94 to
bb73b56
Compare
This was referenced Dec 21, 2023
janmasrovira
approved these changes
Dec 30, 2023
lukaszcz
added a commit
that referenced
this pull request
May 14, 2024
…ter their inductive types (#2768) * Closes #2763. * Fixes a bug in the scoper, likely introduced in #2468 by making later declarations depend on earlier ones. The problem was that the inductive modules were always added at the beginning of a section, which resulted in an incorrect definition dependency graph (an inductive type depended on its associated projections). * Now inductive modules are added just after a group of inductive definitions, before the next function definition. This implies that inductive type definitions which depend on each other cannot be separated by function definitions. Existing Juvix code needs to be adjusted. * The behaviour is now equivalent to "manually" inserting module declarations with projections after each group of inductive definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes checklist
ModuleInfoinJuvix.Compiler.Store.Language)Juvix.Compiler.PipelineJuvix.Compiler.Pipeline.Driverwhich drives the per-module compilation processPipeline.DriverPipeline.DriverPipeline.Driverto avoid excessive disk operations and repeated hash re-computationsInternal.fromConcrete- Fixed by making textually later definitions depend on earlier ones.
- Now instances are used for resolution only after the textual point of their definition.
- Similarly, type synonyms will be unfolded only after the textual point of their definition.