Support MemRepTuple in the Nockma backend
#2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
nockma-memrep
branch
from
094d951 to
7d2d4d6
Compare
paulcadman
force-pushed
the
nockma-memrep
branch
from
3385e7e to
3453cd3
Compare
lukaszcz
reviewed
Jan 23, 2024
| @@ -46,6 +46,7 @@ data ConstructorInfo = ConstructorInfo | |||
| _constructorTag :: Tag, | |||
| _constructorType :: Type, | |||
| _constructorArgNames :: [Maybe Text], | |||
| _constructorArgsNum :: Int, | |||
There was a problem hiding this comment.
_constructorArgsNum is always equal to length (typeArgs _constructorType), I guess? There should be a comment that this field is only a "cache" for this value.
lukaszcz
reviewed
Jan 23, 2024
| mkConstructorInfo ci@Asm.ConstructorInfo {..} = | ||
| ConstructorInfo | ||
| { _constructorInfoArity = fromIntegral _constructorArgsNum, | ||
| _constructorInfoMemRep = nockmaMemRep (memRep ci (getInductiveInfo (ci ^. Asm.constructorInductive))) |
There was a problem hiding this comment.
This is fine, but ultimately it would be good to have a (parameterised) transformation on JuvixTree which calculates the representations. It can only be used with the Nockma pipeline until the C code generation supports the representations, but later it could be re-used.
lukaszcz
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can represent Anoma types like resource as Juvix records.
The Nockma encoding of types uses Nockma 'tuples' where each component of the tuple holds a value of a field. So for Juvix->Anoma integration it is convenient to compile values of record types as Nockma tuples.
We already have the concept of representing constructors of inductive types that have only one non-zero-field constructor in the compiler, see
MemRepTuple.In this PR, as part of the Nockma step, we mark constructors that satisfy the requirements of the
MemRepTupletranslation as such. Then we use a tuple encoding for those constructors.