Use writeFileEnsureLn in place of writeFile
#2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
refactor-writeFile
branch
3 times, most recently
from
dfd5a18 to
4688cb5
Compare
janmasrovira
force-pushed
the
refactor-writeFile
branch
from
4688cb5 to
a606326
Compare
janmasrovira
force-pushed
the
refactor-writeFile
branch
from
a606326 to
8ac7531
Compare
paulcadman
reviewed
Jan 31, 2024
paulcadman
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we guarantee that whenever we write a file there is a newline character at the end, which is a Unix convention.
The juvix prelude now exports
writeFileEnsureLnand it no longer exportswriteFile. If at some point we need the behaviour ofwriteFileI'd suggest that we export it renamed aswriteFileVerbatimor something similar.