Translation from Juvix Tree to Nockma
#2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
2606-translation-from-juvixtree-to-nockma
branch
from
104611c to
155429f
Compare
paulcadman
force-pushed
the
2606-translation-from-juvixtree-to-nockma
branch
from
3a16e26 to
78ab6df
Compare
lukaszcz
force-pushed
the
2606-translation-from-juvixtree-to-nockma
branch
from
555c21a to
04a54b7
Compare
lukaszcz
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Well done! Now the JuvixTree tests can be compiled to Nockma and evaluated in reasonable time. Closures are still very slow, and maybe we'll need to think harder about them in the future, but for now it's fine.
We should still do in separate PRs:
- Tests for the Nockma backend that go all the way from Juvix input, not only from the intermediate JuvixTree language. The native/WASM compilation pipeline tests could be modified for this purpose.
- Make the tests run the external Nockma interpreter in addition to our internal one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the JuvixAsm -> Nockma translation with a JuvixTree -> Nockma translation.
We can now enable some of the JuvixTree tests that did not work with JuvixAsm->Nockma because they were too slow.
Notes
We have changed test031: temp stack with branching to avoid using negative numbers (because negative integers are not supported in Nockma).
Three tree tests trace/output lists. Lists are serialised differently by the asm and nockma pretty printers so they cannot share a single test output file. We have created separate nockma output files for these tests (see eg. test028.nockma.out).