-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace polysemy
by effectful
#2663
Conversation
d261ed8
to
433ccd5
Compare
8544f91
to
ac4e7bf
Compare
I was curious about this PR because this is a nice example of effectful vs polysemy, but I'm very surprised at the second benchmark results. I suspect something's not right with the translation and I was curious enough that I tried to reproduce this locally and I can, but when I tried to build the project with profiling to see what's going on, GHC fails to compile the repline/haskeline module because you do some weird things there and apparently GHC gets confused 😕 |
We were also surprised with that benchmark and we are investigating the cause. I'll share the findings as soon as we have them. |
7590a93
to
42b0bad
Compare
258aaa4
to
9b6a239
Compare
23995e0
to
b3c342d
Compare
The following benchmark compares juvix 0.6.0 with polysemy and a new version (implemented in this pr) which replaces polysemy by effectful.
Typecheck standard library without caching
Typecheck standard library with caching