-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nockma scry #2678
Merged
Merged
Support nockma scry #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
support-nockma-scry
branch
from
March 19, 2024 13:55
08ecfe3
to
0b3c2f1
Compare
paulcadman
force-pushed
the
support-nockma-scry
branch
2 times, most recently
from
March 20, 2024 17:48
2edc12d
to
40be37d
Compare
janmasrovira
previously approved these changes
Mar 21, 2024
This builtin calls Anoma/Nockma scry
Co-authored-by: Jan Mas Rovira <janmasrovira@gmail.com>
Apply this transformation to the Tree->Asm translation.
paulcadman
force-pushed
the
support-nockma-scry
branch
from
March 21, 2024 12:12
40be37d
to
9020516
Compare
janmasrovira
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Anoma/Nockma scry OP. It is used for obtaining values from the Anoma storage (key value store). See the linked issue for details on scry.
This PR adds support for scry to the Nockma language and compilation from the frontend via a builtin:
anoma-get
:In the backend, the
Value
andKey
types could be anything, they will depend on choices of Anoma applications. The type of the returnedValue
is unchecked. It's currently the responsibility of the user to match the annotated type with the type of data in storage.We will not put this builtin in the standard library. It will be exposed in the anoma-juvix library. It's likely that the frontend
anomaGet
function will evolve as we use it to write Anoma applications and learn how they work.