refactor --target into subcommands for dev tree compile and other improvements
#2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
dev-subcommands
branch
from
def0b0c to
573070e
Compare
janmasrovira
changed the title
--target in to subcommands for dev xxx compile--target into subcommands for dev xxx compile
janmasrovira
force-pushed
the
dev-subcommands
branch
2 times, most recently
from
8cf9892 to
afb002e
Compare
janmasrovira
changed the title
--target into subcommands for dev xxx compile--target into subcommands for dev tree compile
janmasrovira
changed the title
--target into subcommands for dev tree compile--target into subcommands for dev tree compile and other improvements
lukaszcz
reviewed
Apr 16, 2024
|
|
||
| instance EntryPointOptions (CasmOptions k) where | ||
| applyOptions opts = | ||
| set entryPointTarget (Just TargetCairo) -- TODO is this the right target? |
There was a problem hiding this comment.
Yes, it's the right target, because CASM can only be compiled to Cairo, so it's useless to make a separate backend target for it (whose purpose is to establish implementation limits like max number of function arguments, etc).
janmasrovira
force-pushed
the
dev-subcommands
branch
from
afb002e to
98ac944
Compare
lukaszcz
approved these changes
Apr 16, 2024
paulcadman
added a commit
that referenced
this pull request
Apr 18, 2024
The wasm32-wasi target was renamed to wasi in #2713
janmasrovira
pushed a commit
that referenced
this pull request
Apr 19, 2024
The wasm32-wasi target was renamed to wasi in #2713
paulcadman
added a commit
that referenced
this pull request
Apr 22, 2024
The wasm32-wasi target was renamed to wasi in #2713
janmasrovira
pushed a commit
that referenced
this pull request
Apr 23, 2024
The wasm32-wasi target was renamed to wasi in #2713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--targetinto subcommands fordev tree compile.Appto allCompileTargetconstructors to avoid name clashes withTarget.AppError MegaparsecErrorinstance and simplify some related code.