Support for Cairo builtins #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
cairo-builtins
branch
from
f5ef1c4 to
d19e9f4
Compare
| @@ -5,7 +5,7 @@ import Juvix.Compiler.Casm.Data.Result | |||
| import Juvix.Compiler.Casm.Language | |||
|
|
|||
| fromCairo :: [Cairo.Element] -> Result | |||
| fromCairo elems0 = Result mempty (go 0 [] elems0) | |||
| fromCairo elems0 = Result mempty (go 0 [] elems0) mempty | |||
There was a problem hiding this comment.
since there are two mempty, it would be more readable with record syntax
paulcadman
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements generic support for Cairo VM builtins. The calling convention in the generated CASM code is changed to allow for passing around the builtin pointers. Appropriate builtin initialization and finalization code is added. Support for specific builtins (e.g. Poseidon hash, range check, Elliptic Curve operation) still needs to be implemented in separate PRs.