Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ghc-9.8.2 #2794

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Upgrade to ghc-9.8.2 #2794

merged 2 commits into from
Jun 8, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented May 31, 2024

haskell lsp 2.8.0.0 (available in ghc-up) is compatible with ghc-9.8.2.
I had to do some renaming in order to avoid shadowing.

@janmasrovira janmasrovira self-assigned this May 31, 2024
@janmasrovira janmasrovira force-pushed the ghc-9.8.2 branch 3 times, most recently from a2e4ef4 to 3a97ebf Compare June 6, 2024 08:46
@janmasrovira janmasrovira marked this pull request as ready for review June 6, 2024 08:53
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The freeze file looks odd, but we can fix it later if it is an issue.

@janmasrovira discretion to merge now or wait.

@janmasrovira
Copy link
Collaborator Author

I'll mark this as draft until the end of the week to minimize risks

@janmasrovira janmasrovira marked this pull request as draft June 6, 2024 11:06
@janmasrovira janmasrovira force-pushed the ghc-9.8.2 branch 2 times, most recently from 3792862 to 407eec8 Compare June 8, 2024 07:05
@janmasrovira janmasrovira marked this pull request as ready for review June 8, 2024 07:05
@janmasrovira janmasrovira force-pushed the ghc-9.8.2 branch 2 times, most recently from a097724 to c8d8cf3 Compare June 8, 2024 09:19
@janmasrovira janmasrovira merged commit 6622d88 into main Jun 8, 2024
4 checks passed
@janmasrovira janmasrovira deleted the ghc-9.8.2 branch June 8, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants