Remove copy propagation from the native/WASM and Rust pipelines #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukaszcz
commented
Jun 20, 2024
lukaszcz
commented
- Closes copy-propagation causes regression in juvix-stdlib test suite #2845
- Copy propagation is not correct without subsequent adjusting of live variables. See the comments in copy-propagation causes regression in juvix-stdlib test suite #2845.
- Enables JuvixReg transformations in the test suite, which exposes the bug.
- Adds a test in JuvixAsm crafted specifically to expose this bug.
paulcadman
approved these changes
Jun 20, 2024
paulcadman
force-pushed
the
fix-copy-propagation
branch
from
39def7f to
d33d969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.