-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger #2908
Logger #2908
Conversation
5e72d03
to
31dc556
Compare
Please open an issue in vscode-juvix once you merge this or another kind of PRs that remove/change the CLI that the vscode extension may depend on. |
app/App.hs
Outdated
args <- askArgs | ||
entry <- getEntryPointStdin' args | ||
r <- runIOEitherPipeline entry (inject p) >>= fromRightJuvixError | ||
return (snd r) | ||
|
||
-- say :: (Member App r) => Text -> Sem r () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed? (I can't delete using GitHub suggestion because there's no way to remove the extra newline)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to remove that. It is now fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Add a smoke test for --ide-end-error-char
|
I've done that in 99e67c9 |
--log-level LOG_LEVEL
flag to the CLI. This flag can be givenerror
,warn
,info
,progress
,debug
as argument to filter the logged messages.--only-errors
flag.--ide-end-error-char CHAR
, which receives a character as an argument, which is appended to the end of error messages. This is handy to facilitate parsing of errors messages from the ide. This functionality was previously embeded in the old--only-errors
flag.