Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger #2908

Merged
merged 23 commits into from
Jul 22, 2024
Merged

Logger #2908

merged 23 commits into from
Jul 22, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jul 18, 2024

  1. Adds the --log-level LOG_LEVEL flag to the CLI. This flag can be given error, warn, info, progress, debug as argument to filter the logged messages.
  2. Removes the --only-errors flag.
  3. Adds the --ide-end-error-char CHAR, which receives a character as an argument, which is appended to the end of error messages. This is handy to facilitate parsing of errors messages from the ide. This functionality was previously embeded in the old --only-errors flag.

@janmasrovira janmasrovira self-assigned this Jul 18, 2024
@janmasrovira janmasrovira force-pushed the logger branch 5 times, most recently from 5e72d03 to 31dc556 Compare July 19, 2024 14:01
@janmasrovira janmasrovira marked this pull request as ready for review July 19, 2024 15:30
@jonaprieto
Copy link
Collaborator

Please open an issue in vscode-juvix once you merge this or another kind of PRs that remove/change the CLI that the vscode extension may depend on.

app/App.hs Outdated
args <- askArgs
entry <- getEntryPointStdin' args
r <- runIOEitherPipeline entry (inject p) >>= fromRightJuvixError
return (snd r)

-- say :: (Member App r) => Text -> Sem r ()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed? (I can't delete using GitHub suggestion because there's no way to remove the extra newline)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove that. It is now fixed

Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Add a smoke test for --ide-end-error-char

@janmasrovira
Copy link
Collaborator Author

Please open an issue in vscode-juvix once you merge this or another kind of PRs that remove/change the CLI that the vscode extension may depend on.

@janmasrovira
Copy link
Collaborator Author

suggestion: Add a smoke test for --ide-end-error-char

I've done that in 99e67c9

@janmasrovira janmasrovira requested a review from paulcadman July 22, 2024 13:48
@janmasrovira janmasrovira merged commit 138d9e5 into main Jul 22, 2024
4 checks passed
@janmasrovira janmasrovira deleted the logger branch July 22, 2024 15:14
@jonaprieto jonaprieto added this to the 0.6.5 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants