Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve css themes #2921

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Improve css themes #2921

merged 8 commits into from
Aug 1, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jul 29, 2024 •
edited
Loading

This pr:

  • Removes the light ayu theme.
  • Adds the light latte theme (this now becomes the default theme).
  • Adds the dark frappe theme.
  • Adds the dark moccha theme.
  • Refactor all source themes to use css variables instead of inlined color definitions. This makes it much easier to maintain.

@janmasrovira janmasrovira force-pushed the css-refactor branch 2 times, most recently from af60968 to bb3a46c Compare July 29, 2024 16:25
@janmasrovira janmasrovira changed the title Work on css themes Improve on css themes Jul 29, 2024
@janmasrovira janmasrovira changed the title Improve on css themes Improve css themes Jul 29, 2024
@janmasrovira janmasrovira self-assigned this Jul 29, 2024
@janmasrovira janmasrovira marked this pull request as ready for review July 29, 2024 16:45
@janmasrovira janmasrovira mentioned this pull request Jul 29, 2024
Merged
@janmasrovira janmasrovira force-pushed the css-refactor branch 4 times, most recently from b64e797 to bda45cc Compare July 31, 2024 17:09
@janmasrovira janmasrovira merged commit fe07c05 into main Aug 1, 2024
4 checks passed
@janmasrovira janmasrovira deleted the css-refactor branch August 1, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

@lukaszcz lukaszcz Awaiting requested review from lukaszcz

Assignees

@janmasrovira janmasrovira

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janmasrovira @paulcadman