-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't write log messages to stdout #3159
Conversation
9f244dc
to
1ab6cdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should suppress git messages
I think we should have logs for when things are being cloned in the normal use-case. Perhaps we could configure the output based on the current log level instead to cover use cases where you don't want them printed? |
I can turn back git messages. They go to stderr, so it's not really a problem. The main thing is redirecting the The problem for markdown generation is that the log goes to stdout. Do you have a reason to write it to stdout? |
1ab6cdd
to
185afb1
Compare
Ideally we would redirect the git messages to the Logger effect, probably on log level info or progress |
But do we need the logger effect to then write it to stdout? If I just change this to stderr, this will already solve the markdown generation problem. |
I mentioned the Logger effect, which prints to stderr, so that it integrates well with the existing cli flags |
|
Changed to stderr now |
Ah, okay, there is also |
41289fc
to
ca81ba4
Compare
ca81ba4
to
22562fb
Compare
The "Cloning (...)" message was written to stdout which messed up markdown generation.