Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to patch tendermint-rs in our codebase #527

Closed
2 tasks done
james-chf opened this issue Sep 29, 2022 · 0 comments
Closed
2 tasks done

Make it easier to patch tendermint-rs in our codebase #527

james-chf opened this issue Sep 29, 2022 · 0 comments

Comments

@james-chf
Copy link
Contributor

james-chf commented Sep 29, 2022

We depend on packages from a fork of the tendermint-rs, and some of our other forks that we depend on (e.g. ibc-rs, tower-abci) also use this tendermint-rs fork. Currently, if we want to update any tendermint-rs packages in the namada workspace, we have to update patching in any of our other forks that are using them as well. This is cumbersome and it should be possible to patch tendermint-rs in the namada codebase without having to patch it in our other forks as well, so long as the version of tendermint-rs we are patching in remains code-compatible with our forks.

For more context on why this is painful, see rust-lang/cargo#7497 and associated issues.

Fix this in the following branches

  • eth-bridge-integration
  • main (this should be fixed when tendermint changes are pushed from eth-bridge-integration branch to main)
@james-chf james-chf self-assigned this Sep 29, 2022
@james-chf james-chf moved this to Todo in Namada-Old Sep 29, 2022
@james-chf james-chf moved this from Todo to Pending Devnet in Namada-Old Oct 3, 2022
@james-chf james-chf moved this from Pending Devnet to WIP in Namada-Old Oct 3, 2022
@james-chf james-chf removed their assignment Oct 11, 2022
Repository owner moved this from WIP to Tested in Devnet in Namada-Old Nov 25, 2022
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
* chore: make e2e tests work with 0.28.0

* fix: cr fixes for setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
1 participant