Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI - governance #3482

Merged
merged 10 commits into from
Jul 30, 2024
Merged

DI - governance #3482

merged 10 commits into from
Jul 30, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jul 3, 2024

Describe your changes

Dependency injection for governance, replacing deps on:

  • parameters
  • trans_token

Indicate on which release or other PRs this topic is based on

Depends-On: #3466

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic marked this pull request as ready for review July 3, 2024 16:40
@tzemanovic tzemanovic requested a review from grarco July 3, 2024 16:40
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 82.01893% with 57 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (1154023) to head (1fbb9fd).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/token/src/lib.rs 25.00% 18 Missing ⚠️
crates/trans_token/src/lib.rs 76.47% 8 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 5 Missing ⚠️
crates/shielded_token/src/vp.rs 0.00% 5 Missing ⚠️
crates/systems/src/test.rs 82.75% 5 Missing ⚠️
crates/governance/src/storage/proposal.rs 0.00% 4 Missing ⚠️
crates/proof_of_stake/src/lib.rs 91.83% 4 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 3 Missing ⚠️
crates/ibc/src/lib.rs 0.00% 2 Missing ⚠️
crates/parameters/src/lib.rs 88.88% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3482      +/-   ##
==========================================
+ Coverage   54.51%   54.54%   +0.03%     
==========================================
  Files         323      324       +1     
  Lines      113288   113438     +150     
==========================================
+ Hits        61762    61880     +118     
- Misses      51526    51558      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco
grarco previously approved these changes Jul 5, 2024
@grarco grarco dismissed their stale review July 5, 2024 13:35

Wasm tests are failing because of an unresolved import. Also affects #3466

tzemanovic added a commit that referenced this pull request Jul 9, 2024
@tzemanovic tzemanovic mentioned this pull request Jul 9, 2024
5 tasks
tzemanovic added a commit that referenced this pull request Jul 10, 2024
grarco
grarco previously approved these changes Jul 10, 2024
grarco
grarco previously approved these changes Jul 15, 2024
Copy link
Contributor

mergify bot commented Jul 30, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

@Fraccaman
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jul 30, 2024

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jul 30, 2024
@mergify mergify bot merged commit d9b61de into main Jul 30, 2024
21 checks passed
@mergify mergify bot deleted the tomas/di-gov branch July 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants