Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/decode asset types #3507

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Murisi/decode asset types #3507

merged 6 commits into from
Aug 13, 2024

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Jul 11, 2024

Describe your changes

This PR makes miscellaneous improvements to the test vector generator:

  • A token being transferred in a shielded Transaction test vector is rendered as an AssetType even when it can and should be decoded into an Address. This PR fixes that.
  • This PR disables the printing of IBC memos in normal mode since its contents are usually unintelligible.
  • Finally, this PR makes the generation of test vectors almost deterministic in order to allow minor changes to be easily made to the formatting of an existing test vector file.

The corresponding changes to the Ledger app are at Zondax/ledger-namada#58 .

Indicate on which release or other PRs this topic is based on

Namada 0.41.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@murisi murisi marked this pull request as ready for review July 11, 2024 11:05
@murisi murisi force-pushed the murisi/decode-asset-types branch from d5f3fc2 to d1b14e3 Compare July 12, 2024 15:52
@murisi murisi force-pushed the murisi/decode-asset-types branch from d1b14e3 to ec20477 Compare July 26, 2024 07:19
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 61.16%. Comparing base (c1f015c) to head (704af7a).
Report is 13 commits behind head on main.

Files Patch % Lines
crates/sdk/src/signing.rs 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3507      +/-   ##
==========================================
- Coverage   61.18%   61.16%   -0.02%     
==========================================
  Files         311      311              
  Lines      101433   101464      +31     
==========================================
  Hits        62059    62059              
- Misses      39374    39405      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi requested a review from tzemanovic August 12, 2024 18:23
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
@tzemanovic tzemanovic removed the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 13, 2024
@tzemanovic
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Aug 13, 2024

refresh

✅ Pull request refreshed

Copy link
Contributor

mergify bot commented Aug 13, 2024

Hey @murisi, your pull request has been dequeued due to the following reason: PR_DEQUEUED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 13, 2024
@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Aug 13, 2024

requeue

☑️ This pull request is already queued

mergify bot added a commit that referenced this pull request Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
Copy link
Contributor

mergify bot commented Aug 13, 2024

Hey @murisi, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Aug 13, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
Copy link
Contributor

mergify bot commented Aug 13, 2024

Hey @murisi, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Aug 13, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
@Fraccaman
Copy link
Member

@Mergifyio dequeue

Copy link
Contributor

mergify bot commented Aug 13, 2024

dequeue

✅ The pull request has been removed from the queue main-queue

@Fraccaman
Copy link
Member

@mergify requeue

Copy link
Contributor

mergify bot commented Aug 13, 2024

Hey @murisi, your pull request has been dequeued due to the following reason: PR_DEQUEUED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

Copy link
Contributor

mergify bot commented Aug 13, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
mergify bot added a commit that referenced this pull request Aug 13, 2024
@mergify mergify bot merged commit e2a1331 into main Aug 13, 2024
19 of 21 checks passed
@mergify mergify bot deleted the murisi/decode-asset-types branch August 13, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants