Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to wasmer 5.0.0 #3981

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Upgrade to wasmer 5.0.0 #3981

wants to merge 3 commits into from

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 5, 2024

Describe your changes

  • Upgrade to wasmer v5.0.0 (see: https://wasmer.io/posts/introducing-wasmer-v5)
  • Introduce an option to run integration tests with wasmer's interpreter mode, introduced in v5.0.0
    • Add code supporting the interpreter mode, hidden under a feature flag
    • Add new makefile target, for instance make test-integration-wasmi, to run the integration tests with the wasm interpreter (rather than the JIT engine)

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 added the wasm label Nov 5, 2024
@sug0
Copy link
Collaborator Author

sug0 commented Nov 5, 2024

To satisfy the second objective, consult: https://github.com/wasmerio/wasmer/blob/v5.0.0/lib/api/Cargo.toml

@sug0 sug0 marked this pull request as draft November 5, 2024 14:17
@sug0 sug0 added this to the Nice to have and non-breaking milestone Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant