migration fixes

[tzemanovic]

Describe your changes

• check that migration file can be decoded on node start-up
• validate migration before starting to commit block to avoid leaving node in corrupt state on failure
• skips writing diffs for migration to close Invalid MerkleTreeStoresRead after restarting a 0.45 to 0.46 upgraded validator #4112 (extended e2e migration test to cover this)
• make sure to update merkle tree to close Invalid MerkleTreeStoresRead after restarting a 0.45 to 0.46 upgraded validator #4112 (extended e2e migration test covers this)
• persist merkle tree update in the same block

Checklist before merging

• If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
  • This will require 2 reviewers to approve the changes
• If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
  • Relevant PR if applies:
• If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
  • Relevant PR if applies:

[tzemanovic]

ah, an integration test is failing

[codecov]

Codecov Report

Attention: Patch coverage is 41.69492% with 172 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (18d2ef0) to head (ffefc11).
Report is 42 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/sdk/src/migrations.rs	32.20%	80 Missing ⚠️
crates/storage/src/mockdb.rs	0.00%	62 Missing ⚠️
crates/node/src/storage/rocksdb.rs	67.07%	27 Missing ⚠️
crates/node/src/lib.rs	0.00%	2 Missing ⚠️
crates/node/src/shell/mod.rs	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4135      +/-   ##
==========================================
- Coverage   74.56%   74.51%   -0.05%     
==========================================
  Files         341      341              
  Lines      107495   107638     +143     
==========================================
+ Hits        80152    80206      +54     
- Misses      27343    27432      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brentstone]

@tzemanovic what's the latest with this branch?

[tzemanovic]

@tzemanovic what's the latest with this branch?

it's rdy to merge whenever we want to include it