Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #4133 from tiago/osmosis-swap-cli-over-v44 #4260

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

tzemanovic
Copy link
Member

Describe your changes

This reverts commit 90771ba, reversing changes made to 04b81b1.

To be re-merged

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

…er-v44"

This reverts commit 90771ba, reversing
changes made to 04b81b1.
@tzemanovic tzemanovic requested a review from brentstone January 21, 2025 14:34
@tzemanovic tzemanovic marked this pull request as ready for review January 21, 2025 15:06
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 88.42593% with 25 lines in your changes missing coverage. Please review.

Project coverage is 74.50%. Comparing base (9c8bb71) to head (a3925c0).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/tx.rs 0.00% 16 Missing ⚠️
crates/ibc/src/context/middlewares/pfm_mod.rs 96.17% 7 Missing ⚠️
crates/ibc/src/msg.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4260      +/-   ##
==========================================
+ Coverage   74.05%   74.50%   +0.44%     
==========================================
  Files         345      344       -1     
  Lines      109782   109317     -465     
==========================================
+ Hits        81303    81450     +147     
+ Misses      28479    27867     -612     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic merged commit d1b9fb9 into main Jan 21, 2025
30 of 31 checks passed
@tzemanovic tzemanovic deleted the tomas/rev-osmosis branch January 21, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant