[#24] Support Multiline comments #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrom911
commented
May 1, 2023
src/highlighting.ts
Outdated
| @@ -107,7 +109,7 @@ export class Highlighter implements vscode.DocumentSemanticTokensProvider { | |||
| '--format', | |||
| 'json', | |||
| filePath, | |||
| '--stdin', | |||
| // '--stdin', | |||
There was a problem hiding this comment.
This is because for some reason this prevents highlight command from working.
I am investigating this, but commenting this out allows everything work properly
There was a problem hiding this comment.
I fixed this in anoma/juvix#2043
So this will work with that changes in place 🙂
vrom911
changed the title
As it is now fixed in the juvix branch, this is the proof that it works as before with the stdin option
jonaprieto
force-pushed
the
vrom911/24-Multiline-comments-are-not-colored
branch
from
416bdb2 to
409cc7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the whole multiline comment is highlighted for me: