Windows spawn ENOENT error in OpenCode SDK

[alanjaouen]

The OpenCode SDK fails on Windows with 'spawn opencode ENOENT' error. The spawn() calls need { shell: true } option to resolve executables properly on Windows. Affects createOpencodeServer() and createOpencodeTui() functions in packages/sdk/js/src/server.ts

[github-actions]

This issue might be a duplicate of existing issues. Please check:

• ENOENT error when referencing file paths in OpenCode AI CLI (windows) #2799: ENOENT error when referencing file paths in OpenCode AI CLI (windows) - similar Windows ENOENT error, though CLI-related rather than SDK-related

Feel free to ignore if none of these address your specific case.

[rekram1-node]

@itsrainingmani

[cspotcode]

Beware the caveats of shell: true: https://nodejs.org/api/child_process.html#child_processspawncommand-args-options

If the shell option is enabled, do not pass unsanitized user input to this function. Any input containing shell metacharacters may be used to trigger arbitrary command execution.

Shell is only necessary if we need to execute a .cmd or .bat script, if where.exe opencode points to a text script instead of an executable.

You might consider using execa to handle this complexity for you, rather than risking it with shell: true?
https://github.com/sindresorhus/execa

More on Windows' spawn complexity: https://github.com/moxystudio/node-cross-spawn?tab=readme-ov-file#why

[rekram1-node]

good callout