fix(opencode): resolve performance bottleneck in prompt loop#10190
Open
illuxiza wants to merge 3 commits intoanomalyco:devfrom
Open
fix(opencode): resolve performance bottleneck in prompt loop#10190illuxiza wants to merge 3 commits intoanomalyco:devfrom
illuxiza wants to merge 3 commits intoanomalyco:devfrom
Conversation
Replace expensive remeda clone() with lazy shallow copying that only copies messages/parts that actually need modification. This fixes 30+ second delays when sending messages in sessions with 200+ messages. Fixes anomalyco#10187
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace expensive remeda clone() with lazy shallow copying that only copies messages/parts that actually need modification.
This fixes 30+ second delays when sending messages in sessions with 200+ messages.
What does this PR do?
This PR replaces the expensive
remeda.clone()call in [packages/opencode/src/session/prompt.ts] with a performance-optimized lazy shallow copy pattern.The Problem:
In the main prompt loop, the code was performing a full deep clone of the entire message history on every iteration. For large sessions (200+ messages), this expensive operation caused extreme performance degradation, resulting in 30-180 second delays before the LLM could start generating tokens.
The Solution:
Implemented a lazy mapping strategy. Instead of cloning everything defensively:
<system-reminder>).How did you verify your code works?
system-reminderwrapper is still correctly applied to new user messages as expected.Fixes #10187