-
Notifications
You must be signed in to change notification settings - Fork 9k
feat(desktop): add setting to open links in external browser #10310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:PR #8523: feat(desktop): open external links in system browser instead of webview Why it's related:This PR appears to address the same feature - allowing users to open external links in the system browser instead of within the desktop app. PR #10310 seems to build upon or refine this concept by adding it as a configurable setting rather than always opening externally. |
4c1adb2 to
676873e
Compare
|
Thanks for flagging this! Yes, there's overlap with #8523. Here's a comparison:
This PR is intentionally minimal - just a Settings toggle without extra UI elements. PR #8523 has more features but is also more complex. Happy to defer to #8523 if the maintainers prefer that approach, or this could serve as a simpler alternative. The core click handler logic is similar in both. |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
29e940d to
2c3d742
Compare
|
Rebased on latest Changes made during rebase:
|
CI Status Update ✅All checks are passing:
Ready for review and merge. |
990052c to
bada199
Compare
|
Recreated cleanly from |
bada199 to
2bacdb6
Compare
Add a toggle in Settings > General > Desktop to open links in the system's default browser instead of within the app. - Desktop IPC handler for external link opening - Settings context: browser.openLinksExternally state - Settings UI: toggle in Desktop section - i18n: translations for all 15 languages
Remove flex-wrap and add flex-1 to the text container so the toggle switch stays inline even with long description text.
2bacdb6 to
02ce52e
Compare

Summary
Adds a new setting in Settings → General → Browser that allows users to choose whether clicking links should open them in the system's default browser (default) or within the desktop app.
Changes
BrowserSettingsinterface withopenLinksExternallyoptionScreenshots
The new setting appears in Settings → General → Browser section (desktop only).
Motivation
Currently, clicking on links in the desktop app opens them within the app itself. This can be frustrating when you want to open links in your default system browser instead, to use features like:
Closes #10309