fix(app) internal/external link handling #10752
Open
+107
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10613, #8361
What does this PR do?
fixes the external link handling issue that was reverted in #10697
The previous implementation broke internal app navigation (sessions, settings,
etc.) because it opened ALL links externally, regardless of whether they were
internal or external to the app.
Now properly distinguishes between internal and external links by comparing
origins.
Changes
How did you verify your code works?
Tested in a dev desktop build, dev web build, and in a release desktop build