fix(bash): detect external directories without realpath#10874
Open
MaxMiksa wants to merge 1 commit intoanomalyco:devfrom
Open
fix(bash): detect external directories without realpath#10874MaxMiksa wants to merge 1 commit intoanomalyco:devfrom
MaxMiksa wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
|
we really should not add more of these custom regexps scattered throughout 100 places in the code, with self-made resolve functions made by AI |
MaxMiksa
force-pushed
the
fix/bash-external-dir-detect
branch
from
b09eb27 to
eef2d8f
Compare
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
4 times, most recently
from
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10872
What does this PR do?
Removes the
realpathexternal dependency from bash tool path detection by using internal resolution (path.resolve) withfs.realpathfallback, soexternal_directoryprompts still happen whenrealpathis missing.How did you verify your code works?
bun run --cwd packages/opencode typecheckbun test test/tool/bash.test.ts -t "realpath is missing"(regression test)