fix(tui): read tool uppercase/mixed case image extensions#11333
Open
alexyaroshuk wants to merge 2 commits intoanomalyco:devfrom
Open
fix(tui): read tool uppercase/mixed case image extensions#11333alexyaroshuk wants to merge 2 commits intoanomalyco:devfrom
alexyaroshuk wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: PR #11312: fix(app): binary file handling in file view This PR appears to be related as it also addresses binary file handling issues. However, it's focused on the file view in the app rather than the CLI/TUI read tool specifically. You should verify if this addresses the same underlying issue or if they're separate concerns. The current PR #11333 is the primary match for your search terms, which is the PR you're currently checking (so not a duplicate of itself). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10916
What does this PR do?
The problem:
read frame.PNG, .Png, .pNG, etc. returned "Cannot read binary file" error
read frame.png worked fine
Bun's MIME type detection doesn't handle uppercase extensions correctly
The fix: Added extension-based image detection before MIME type detection:
Check file extension (case-insensitive)
Map extension to correct MIME type (png→image/png, jpg→image/jpeg, etc.)
Handle image immediately if extension matches
How did you verify your code works?
Before:
After