fix(acp): handle permission requests from child sessions #12136
+79
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Task subagents create child sessions, they are not registered in the ACP session manager. This caused permission requests from those sessions to be silently ignored, freezing the session indefinitely.
What does this PR do?
Fixes #12133. Now fetches session info from SDK when the session is not found in the manager, allowing permission requests from child sessions to be properly forwarded to the ACP client.
How did you verify your code works?
I created a super simple ACP test client in Python that tests permission requests from Task subagents are properly forwarded to the ACP client (which auto-accepts the permission) by spawning 4 parallel OpenCode ACP processes (2 prod, 2 dev) with two prompts:
Baseline:
Test:
The
prod-permis EXPECTED to fail and time out (because the permissions never get forwarded, thus the ACP client just doesn't ever know it needs to do something)test_acp.py