Skip to content

Conversation

@MBanucu
Copy link
Contributor

@MBanucu MBanucu commented Feb 7, 2026

Updates nixpkgs in flake.lock to a rev that includes bun 1.3.8+, fixing the build failure caused by the script requiring bun@^1.3.8 while the lock had bun 1.3.6.

The issue was introduced when the packageManager was updated to bun@1.3.8, but the flake.lock remained pinned to an older nixpkgs rev.

Fixes #12602

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

Hey! Your PR title Fix flake.lock to resolve bun version issue doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@MBanucu MBanucu changed the title Fix flake.lock to resolve bun version issue chore: update flake.lock to include bun 1.3.8+ Feb 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@MBanucu
Copy link
Contributor Author

MBanucu commented Feb 7, 2026

Tested locally: the fix-flake-lock branch builds successfully with the updated nixpkgs rev including bun 1.3.8.

@ProdigyRahul
Copy link
Contributor

bruh :) just remove dependencies and reinstall using bun i :) this is not the solution

@zaninime
Copy link

zaninime commented Feb 7, 2026

#11919 landed in master already

jerome-benoit added a commit to jerome-benoit/opencode that referenced this pull request Feb 7, 2026
Bun 1.3.8+ with filtered installs (--filter flag) may not create the
node_modules/.bun directory. Add safeReadDir (consistent with
normalize-bun-binaries.ts) and early exit when directory is missing.

Fixes anomalyco#12632, anomalyco#12603, anomalyco#12602
jerome-benoit added a commit to jerome-benoit/opencode that referenced this pull request Feb 7, 2026
Use safeReadDir (consistent with normalize-bun-binaries.ts) and replace
dynamic semver import with Bun.semver.order to remove dependency on
.bun/node_modules/semver.

Fixes anomalyco#12632, anomalyco#12603, anomalyco#12602
jerome-benoit added a commit to jerome-benoit/opencode that referenced this pull request Feb 7, 2026
Use safeReadDir and isDirectory helpers (consistent with
normalize-bun-binaries.ts) and replace dynamic semver import with
Bun.semver.order.

Fixes anomalyco#12632, anomalyco#12603, anomalyco#12602
@MBanucu
Copy link
Contributor Author

MBanucu commented Feb 8, 2026

#12603 (comment)
bruh :) just remove dependencies and reinstall using bun i :) this is not the solution

@ProdigyRahul what do you mean? bun install does not work in nix packages. The best solution that I found until now is bun2nix. The next best solution is to remove the bun install step from the flake and then bun will install the dependencies automatically in a cache folder on first use of opencode. Somehow like this. But this all does not solve the problem of the strict bun version requirement as package manager. flake.lock has to be upgraded if the bun version in package.json is upgraded. I don't know how to work around that and I think you shouldn't.

@MBanucu
Copy link
Contributor Author

MBanucu commented Feb 8, 2026

#11919 Tested, fixed, good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake.lock pinned to outdated nixpkgs rev causing build failure

3 participants