Skip to content

Conversation

@jerome-benoit
Copy link
Contributor

@jerome-benoit jerome-benoit commented Feb 9, 2026

Fixes #12817
Fixes #12811

nix/scripts/*.ts and patches/* are included in the node_modules derivation. Changes to these files invalidate output hashes but didn't trigger the workflow.

  • Add nix/node_modules.nix, nix/scripts/**, and patches/** to paths trigger
  • Remove non-existent install/ from fileset

Copilot AI review requested due to automatic review settings February 9, 2026 12:14
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the nix-hashes GitHub Actions workflow triggers so it reruns when Nix inputs that affect the node_modules derivation change, preventing stale nix/hashes.json updates.

Changes:

  • Add nix/node_modules.nix to the workflow paths trigger.
  • Add nix/scripts/** to the workflow paths trigger so script changes also trigger hash recomputation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jerome-benoit jerome-benoit force-pushed the fix/nix-hashes-watch-scripts branch from 106d6b0 to 2cf3779 Compare February 9, 2026 12:20
nix/scripts/*.ts and patches/* are included in node_modules derivation.
Changes to these files invalidate hashes but didn't trigger rebuild.

Also removes non-existent install/ from node_modules.nix fileset.

Fixes anomalyco#12817
@jerome-benoit jerome-benoit force-pushed the fix/nix-hashes-watch-scripts branch from 2cf3779 to 2a99a1c Compare February 9, 2026 12:22
@gigamonster256
Copy link
Contributor

LGTM

@rekram1-node rekram1-node merged commit 24fd8c1 into anomalyco:dev Feb 9, 2026
6 checks passed
@gigamonster256
Copy link
Contributor

@jerome-benoit @rekram1-node actually nevermind, the desktop build needs the install script

Cannot build '/nix/store/jrkk83ywjk3pvvsr46lzxc3f7x0a0gnn-opencode-desktop-1.1.53-5be1202-dirty.drv'.
Reason: builder failed with exit code 1.
Output paths:
 /nix/store/bgwaaavb52cmpn76dw6qs1sijvwp4s1x-opencode-desktop-1.1.53-5be1202-dirty
Last 25 log lines:
> error: couldn't read `src/../../../../install`: No such file or directory (os error 2)
>   --> src/cli.rs:56:30
>    |
> 56 | const INSTALL_SCRIPT: &str = include_str!("../../../../install");
>    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> warning: unused import: `process::Command`
>   --> src/lib.rs:25:5
>    |
> 25 |     process::Command,
>    |     ^^^^^^^^^^^^^^^^
>    |
>    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
>
> warning: unused variable: `app_name`
>    --> src/lib.rs:237:20
>     |
> 237 | fn check_linux_app(app_name: &str) -> bool {
>     |                    ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_name`
>     |
>     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
>
> warning: `opencode-desktop` (lib) generated 2 warnings
> error: could not compile `opencode-desktop` (lib) due to 1 previous error; 2 warnings emitted
>        Error failed to build app: failed to build app

jerome-benoit added a commit to jerome-benoit/opencode that referenced this pull request Feb 9, 2026
The install script was incorrectly removed in anomalyco#12818. It is required
by the desktop build as cli.rs uses include_str!("../../../../install").

Fixes the regression reported in anomalyco#12818 comments.
jerome-benoit added a commit to jerome-benoit/opencode that referenced this pull request Feb 9, 2026
The install script was incorrectly removed in anomalyco#12818. It is required
by the desktop build as cli.rs uses include_str!("../../../../install").

Fixes the regression reported in anomalyco#12818 comments.
fanjia1024 pushed a commit to fanjia1024/opencode that referenced this pull request Feb 10, 2026
BryceRyan pushed a commit to BryceRyan/opencode that referenced this pull request Feb 10, 2026
avion23 pushed a commit to avion23/opencode that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nix-hashes workflow doesn't watch nix/scripts changes Update nix hashes, please

3 participants