-
Notifications
You must be signed in to change notification settings - Fork 10k
fix(nix): watch scripts in nix-hashes workflow #12818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nix): watch scripts in nix-hashes workflow #12818
Conversation
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the nix-hashes GitHub Actions workflow triggers so it reruns when Nix inputs that affect the node_modules derivation change, preventing stale nix/hashes.json updates.
Changes:
- Add
nix/node_modules.nixto the workflowpathstrigger. - Add
nix/scripts/**to the workflowpathstrigger so script changes also trigger hash recomputation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
106d6b0 to
2cf3779
Compare
nix/scripts/*.ts and patches/* are included in node_modules derivation. Changes to these files invalidate hashes but didn't trigger rebuild. Also removes non-existent install/ from node_modules.nix fileset. Fixes anomalyco#12817
2cf3779 to
2a99a1c
Compare
|
LGTM |
|
@jerome-benoit @rekram1-node actually nevermind, the desktop build needs the install script Cannot build '/nix/store/jrkk83ywjk3pvvsr46lzxc3f7x0a0gnn-opencode-desktop-1.1.53-5be1202-dirty.drv'.
Reason: builder failed with exit code 1.
Output paths:
/nix/store/bgwaaavb52cmpn76dw6qs1sijvwp4s1x-opencode-desktop-1.1.53-5be1202-dirty
Last 25 log lines:
> error: couldn't read `src/../../../../install`: No such file or directory (os error 2)
> --> src/cli.rs:56:30
> |
> 56 | const INSTALL_SCRIPT: &str = include_str!("../../../../install");
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> warning: unused import: `process::Command`
> --> src/lib.rs:25:5
> |
> 25 | process::Command,
> | ^^^^^^^^^^^^^^^^
> |
> = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
>
> warning: unused variable: `app_name`
> --> src/lib.rs:237:20
> |
> 237 | fn check_linux_app(app_name: &str) -> bool {
> | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_name`
> |
> = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
>
> warning: `opencode-desktop` (lib) generated 2 warnings
> error: could not compile `opencode-desktop` (lib) due to 1 previous error; 2 warnings emitted
> Error failed to build app: failed to build app |
The install script was incorrectly removed in anomalyco#12818. It is required by the desktop build as cli.rs uses include_str!("../../../../install"). Fixes the regression reported in anomalyco#12818 comments.
The install script was incorrectly removed in anomalyco#12818. It is required by the desktop build as cli.rs uses include_str!("../../../../install"). Fixes the regression reported in anomalyco#12818 comments.
Fixes #12817
Fixes #12811
nix/scripts/*.tsandpatches/*are included in thenode_modulesderivation. Changes to these files invalidate output hashes but didn't trigger the workflow.nix/node_modules.nix,nix/scripts/**, andpatches/**to paths triggerinstall/from fileset