feat(session modal): introduce session bookmarking #1843

spoons-and-mirrors · 2025-08-12T03:34:04Z

Building on #1821

With pins

Pinned sessions only

github-actions

This violates the AGENTS.md guideline: "PREFER single word variable names where possible". Consider: Use id instead of sessionID and session instead of updatedSession

github-actions

This violates the AGENTS.md guideline: "PREFER single word variable names where possible". Consider: Use id instead of sessionID in function parameters

github-actions

Multiple variables violate the AGENTS.md guideline: "PREFER single word variable names where possible". Consider shorter names like: selectedSession -> selected, filteredSessions -> filtered, newTitle -> title, deleteConfirmationID -> confirmID, etc.

packages/opencode/src/server/server.ts

packages/tui/internal/components/dialog/session.go

packages/opencode/src/session/index.ts

thdxr · 2025-08-12T18:38:15Z

lol ignore these reviews they're garbage

adamdotdevin · 2025-08-13T01:03:59Z

love the idea of pinning sessions, but a few UX/visual nits:

i don't love the emojis, can we indicate pins another way?
that bottom menu is getting a bit crowded; can we just always show with pins at the top, do we need to toggle?

spoons-and-mirrors · 2025-08-13T01:22:31Z

yeah sorry I didn't update after my latest commit, I didn't like the pins either and moved to a dot with success color (but had some troubles with the background when highlighting, showing a black box...)

anywho, it now looks like that

I realize that pinning is actually a miss-use of the term on my part, I was more thinking of a "bookmark" system.
I feel it doesn't make sense to push the pins/bookmark at the top of the session list, but rather leave them where they are in the item list. This is why I think the bookmark view is a good addition, to filter and only show our bookmarked sessions. It feels more organized this way rather than constantly pushing things at the top when we mark them.

Example:
You make a few research sessions and move on to something else. Then later, you go and bookmark those research sessions because they had insight you will need at some point, but not now. It doesn't make sense to me to push them at the top, they will just be a nuisance. Plus if you have say 10 pins, you will have to scroll to see your working sessions.

Regarding the footer being too crowded, we could maybe change:

n new session -> n new
P pinned view > P filter
and maybe add 2 spaces between shortcuts:
n new r rename p pin P filter
or 3
n new r rename p pin P filter (I like 3 better)
we could also use a warning color for the letter shortcut adding some dynamism to the footer?

The highlight issue I mentioned is this

EDIT: fixed!

PS: maybe TAB is a better way of toggling to the filtered view?

Enable users to rename sessions directly from the session modal by pressing 'r' key. - Add PATCH /session/:id API endpoint for updating session title - Extend Go SDK with UpdateSession method and SessionUpdateParams type - Add UpdateSession method to TUI app for API integration - Implement rename mode in session modal with textinput component - Update modal help text to show 'r rename' option - Handle Enter/Esc for confirm/cancel rename operations 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>

Change the session modal title from "Switch Session" to "Rename Session" when user enters rename mode, providing clearer context for the current operation. 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>

…g modal When in session rename mode, pressing ESC now exits rename mode and returns to the session list view instead of closing the modal entirely. This provides a more intuitive user experience. - Add ReopenSessionModalMsg to handle rename mode ESC behavior - Modify sessionDialog.Close() to detect rename mode and reopen modal - Add TUI handler for ReopenSessionModalMsg to recreate session modal - Remove explicit ESC handling from rename mode (now handled by Close method) 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>

- `p` to pin session in the session modal - `shift+p` to see pinned session only

…e top. changing the ugly pin for a dot with success color.

…warning color, spacing, labels) and bind bookmarks to TAB

spoons-and-mirrors · 2025-08-14T23:27:38Z

Hey @adamdotdevin, here's how the suggestions look like