WIP feat: add chatgpt auth login #2453
Open
+146
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
in china right now so i cannot properly test authenticating in with a new token, but will check it in the office on monday |
ScriptedAlchemy
changed the title
|
Does it allow us to use the pro package quota ? |
Contributor
|
I might be missing this in the code, but what about the token refresh logic? |
Contributor
|
This would be nice to have in if it allows to use the Pro quota |
github-actions
bot
force-pushed
the
dev
branch
from
f16de3d to
cc0d460
Compare
github-actions
bot
force-pushed
the
dev
branch
from
772b621 to
eb855e1
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f1dc981 to
3e15a39
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f8ee907 to
6a9856d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the authentication flow for the OpenAI provider in the CLI, giving users a choice between logging in with ChatGPT (OAuth) or using an API key. It also introduces a more robust OAuth login implementation and adds a custom header for requests to the OpenAI API. The most important changes are grouped below:
OpenAI Authentication Improvements:
auth login. If "Sign in with ChatGPT" is selected, the new OAuth flow is initiated.Provider Request Customization:
originator: "codex_cli_rs"header to all OpenAI API requests to help identify requests coming from this codex (might not be needed, will confirm).