-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix: merge plugin selections (resolves #4565) #4724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merge plugin selections (resolves #4565) #4724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we undo this? Whyd we change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto?
|
2 nits but looks good |
|
Not sure why or how that file changed, I will revert it back to match HEAD. |
|
Done. |
|
/oc update the plugin merging so that it uses a set to prevent duplicates |
|
Excellent! All typechecks pass. Let me create a summary of what was changed: SummaryI've successfully updated the plugin merging logic in Changes MadeFile:
File:
Benefits
Verification
The change is minimal, focused, and maintains the existing plugin merging behavior while adding deduplication to prevent duplicates as requested. |
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
|
Thank you! |

Resolves #4565.
I stumbled onto a version of 4565 myself while I was messing around editing opencode's source: when I launched opencode in it's own source directory, my bell plugin at
~/.config/opencode/plugin/bell.ts(just plays a sound when the session idles, nothing fancy) stopped making noise. After poking around a bit, I discovered that this was a consequence ofopencode/.opencode/opencode.jsoncspecifying plugin selections, which were replacing (instead of being combined with) my own globally selected plugins.This PR fixes that, merging the globally selected plugins with those selected locally in the project.