-
Notifications
You must be signed in to change notification settings - Fork 7k
feat: add tui.copy_on_select setting to allow disabling copy-on-select behaviour (resolves #4751, resolves #2845) #4793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ariane-emory
wants to merge
50
commits into
anomalyco:dev
from
ariane-emory:feat/copy-on-select-setting
Closed
feat: add tui.copy_on_select setting to allow disabling copy-on-select behaviour (resolves #4751, resolves #2845) #4793
ariane-emory
wants to merge
50
commits into
anomalyco:dev
from
ariane-emory:feat/copy-on-select-setting
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolved conflicts in TUI config schema to include both copy_on_select and diff_style fields - Updated Go SDK to include both new TUI configuration options - Maintained copy-on-select feature implementation while incorporating upstream changes
f8ee907 to
6a9856d
Compare
Contributor
Author
|
Some of the churn in |
…/opencode into feat/copy-on-select-setting
…/opencode into feat/copy-on-select-setting
…/opencode into feat/copy-on-select-setting
|
FYI #4996 may solve this for you |
Contributor
Author
|
@andy-blum indeed, looks like PR#4996 handles the same issue and was already merged. I'll close this PH, then. Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4751, resolves #2845.
I saw this issue and decided that I'd take a stab at resolving it. This PR adds a
tui.copy_on_selectsetting allowing the copy-on-select behaviour to be disabled if desired. Valid values for this setting aretrueandfalse.Enable it in
opencode.jsoncas follows: