core: add built-in Dart LSP server and formatter #4841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can now get Dart language support and formatting automatically without manual configuration when dart command is available
Collaborator
|
Yeah no issue needed, I generally just ask people do that if they try adding some big feature or larger ux change. things like this, fixes, improvements are all always welcome and I want the barrier to entry to be very low But some people come in and wanna completely redesign the whole app and expect me to just merge it hahaa |
Contributor
Author
|
@rekram1-node hahaha I understand. Thank you for merging :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working a lot with Flutter / Dart, so when I've noticed that
darthas a built-in LSP I've tried it.I have no hard evidence, but subjectively the Models seam to be less lost and perform better with the LSP, so I think this might be useful for others too.
Benefits:
Users can now get Dart language support and formatting automatically without manual configuration when dart command is available
I haven't opened an Issue for this, because if I understood contributing guidelines correctly, it's not needed for such change.
Let me know if any changes or further clarification is needed :D