GitHub pull request event #5335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed comment filtering logic to handle both comment events and pull_request events: - Use triggerCommentId which is undefined for pull_request events - Guard reaction functions to handle undefined triggerCommentId - Simplify comment filtering to exclude trigger comment only for comment events
- For comment events: add/remove reactions to/from the comment - For pull_request events: add/remove reactions to/from the PR body - This ensures reactions work correctly regardless of the trigger event type
Contributor
Author
|
It seems the action failed due to request timeout, doesn't seem related to this PR... but i can't retry the job... |
# Conflicts: # packages/opencode/src/cli/cmd/github.ts
Contributor
Author
|
@rekram1-node i've fixed conflicts... lemme your thoughts or you wanna further discuss this on Discord |
Collaborator
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
@rekram1-node i already fixed this comment... i pushed at the same time you commented it seems 😬 |
Collaborator
|
/review |
Collaborator
|
sorry that i spam /review it's just helpful because it catches things I miss |
Contributor
|
lgtm |
iljod
pushed a commit
to iljod/opencode
that referenced
this pull request
Dec 23, 2025
rekram1-node
pushed a commit
that referenced
this pull request
Dec 27, 2025
anntnzrb
pushed a commit
to anntnzrb/opencode-1
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of: #4828
So this add proper support for pull request events, allowing you do add automatic reviews for example: