Skip to content

fix(enterprise): remove deferStream to fix share page hydration mismatch #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
code-yeongyu wants to merge 1 commit into from
Closed

fix(enterprise): remove deferStream to fix share page hydration mismatch #5511

code-yeongyu wants to merge 1 commit into from

Conversation

@code-yeongyu
Copy link
Contributor

@code-yeongyu code-yeongyu commented Dec 14, 2025 •
edited
Loading

Summary

  • Remove deferStream: true from share page route to fix blank page issue with large session data

Problem

Share pages with large data (3.5MB+) render as completely blank pages. The $R hydration promises never resolve, leaving #app with only a Solid marker comment.

Observed behavior:

  • #app innerHTML: <!--!$e000000010000000020000000010--> (empty)
  • $R object: 790 keys loaded, but R[0], R[3], R[5] stuck as unresolved promises
  • No JavaScript errors in console

Root Cause

deferStream: true was added in commit 95526fb (Dec 11, 2025) with the intent to fix share image meta tags. However, this causes streaming chunk processing failures with large payloads:

  1. Server sends data as streaming chunks (not inline in initial HTML)
  2. Large chunks (3.5MB) can fail silently - CDN buffering, truncation, or main thread blocking
  3. Client waits indefinitely for chunks that never properly resolve
  4. Result: permanent blank page with no error indication

Solution

Remove deferStream: true to ensure data is embedded in initial HTML rather than streamed. This guarantees hydration completes regardless of payload size.

OG Image Impact: None (No Regression)

Removing deferStream does not affect OG images because they are already broken in production:

$ curl -sA "facebookexternalhit" "https://opncd.ai/share/vBB6Ttga" | grep og:image
# (no output - OG tags missing)

Why OG tags don't work (regardless of deferStream):

The <Meta property="og:image"> tag is inside <Show when={data()}>:

<Show when={data()}>
  {(data) => (
    <>
      <Meta property="og:image" content={ogImage()} />  // Inside Show
      ...
    </>
  )}
</Show>

Since <head> is sent before data() resolves, OG meta tags are never included in the initial HTML response. This is a separate issue that requires moving meta tags outside of <Show>.

Scenario OG Image Page Render
Before (deferStream: true) ❌ Broken ❌ Blank (large data)
After (deferStream removed) ❌ Broken (unchanged) ✅ Works

Testing

  • Tested with production share data (3,522,667 chars / 3.5MB)
  • Browser test confirms page renders correctly after fix
  • Verified OG tags are absent both before and after change

Related

🤖 GENERATED WITH ASSISTANCE OF OhMyOpenCode

@code-yeongyu
fix(enterprise): remove deferStream to fix share page hydration mismatch
b6d138e 
deferStream: true causes hydration issues with large share data (97KB+).
Removing it ensures complete HTML generation before response, fixing
blank page rendering on https://opncd.ai/share/* routes.

🤖 GENERATED WITH ASSISTANCE OF [OhMyOpenCode](https://github.com/code-yeongyu/oh-my-opencode)
@Raviguntakala Raviguntakala mentioned this pull request Dec 14, 2025
Closed
@code-yeongyu
Copy link
Contributor Author

code-yeongyu commented Dec 16, 2025

Hi am i only one experiencing this issue

@code-yeongyu
Copy link
Contributor Author

code-yeongyu commented Dec 16, 2025

Wanna share my sweet talk i had with opus to my friends but this barrier blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Share page is completely empty, and /unshare does nothing

1 participant

@code-yeongyu