Fix MCP OAuth auth commands to recognize remote servers by default #5537
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled by default - Updated CLI checks to use MCP.supportsOAuth() instead of requiring explicit oauth config - Remote MCP servers now support OAuth authentication without needing 'oauth' in config - Fixes issue where 'opencode mcp auth' showed no OAuth servers for remote configs Closes anomalyco#5444
Collaborator
|
/review |
Collaborator
|
looks like there are some type errors |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@shamil2 will you fix this? o.w. I'll open a new PR |
Collaborator
|
still has type errors @shamil2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where MCP OAuth authentication commands didn't recognize remote MCP servers as OAuth-enabled unless explicitly configured with 'oauth' in the config.
Changes
MCP.supportsOAuth()functionRoot Cause
The CLI was checking
!!cfg.oauthbut the server enables OAuth for remote servers by default unlessoauth: false. This created a mismatch where servers would accept OAuth but the CLI wouldn't show them as OAuth-capable.Closes #5444