fix: use correct octokit API for PR review comment reactions #5778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When commenting on files in a PR/lines in a PR, opencode attempts to react (with eyes) and fails with a 404, breaking the workflow. This does not occur for issue comments.
There are two different APIs for this via octokit:
octokit.reactions.createForIssueCommentoctokit.reactions.createForPullRequestReviewCommentopencode did not distinguish between the two - in
packages/opencode/src/cli/cmd/github.tstheaddReaction()function only worked for issues. I noticed this in my own GH reaction handling and had to make a similar fix.This PR fixes this by passing a
commentTypeparameter toaddReaction()andremoveReaction()functions and then using that to switch on the right octokit methods.(It appears this hasn't been a flow others have run into before? The rest of the PR comment handling looks to be there + OK)