Fix a few mobile screen size issues #6808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old, broken. Notice how "add project" is off-screen
bad.mp4
new, with some scaling. everything fits in a mobile width
good.mp4
The height of the main app was set to 100vh (
h-screen). This was causing it to get clipped by the navbar on iOS 26 Safari. I've changed it toh-dvhto be the height of the "dynamic" viewport, depending on the scroll position. Since the main window doesn't scroll, we could probably just doh-svhto do the "small" viewport and avoid the potential performance issue but that felt like premature optimization, since I didn't do any testing on other devices or profiling.old, clipped bottom prompt bar
New, not clipped bottom prompt bar
Photos taken on iPhone 17 Pro Max with iOS 26.3 and tabs set to "compact"