/editor: non-successful editor exits should keep the text in the textarea#693
Closed
Schniz wants to merge 2 commits intoanomalyco:devfrom
Closed
/editor: non-successful editor exits should keep the text in the textarea#693Schniz wants to merge 2 commits intoanomalyco:devfrom
Schniz wants to merge 2 commits intoanomalyco:devfrom
Conversation
Schniz
force-pushed
the
schniz/non-successful-editor-exit
branch
from
20bd568 to
3c82c24
Compare
Contributor
|
we just added attachments, and we need to avoid |
Contributor
Author
|
Ack so I’ll figure out a different way. Probably just not removing in the first place. |
…area # Conflicts: # packages/tui/internal/tui/tui.go
Only clear textarea when external editor exits successfully, rather than clearing immediately and restoring on failure. This simpler approach prevents content loss when the editor exits with non-zero status. 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
Schniz
force-pushed
the
schniz/non-successful-editor-exit
branch
from
83f6876 to
cd84116
Compare
Contributor
Author
|
@adamdotdevin i asked opencode to rebase and make sure to support them attachments. It works, but the main issue I can see is that attachments in /editor are not well supported and get cleared. But that's unrelated to this PR--it is how it works right now in |
github-actions
bot
force-pushed
the
dev
branch
from
f16de3d to
cc0d460
Compare
github-actions
bot
force-pushed
the
dev
branch
from
772b621 to
eb855e1
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f1dc981 to
3e15a39
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f8ee907 to
6a9856d
Compare
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when doing :cq i assume that the textarea cobtent will not have my changes in vim, but also dont clear up the content (which is what it currently does).
This PR ensures that :cq will avoid overwriting the textarea with emoty xontent