Skip to content

fix(permission): trigger permission.ask plugin hook in PermissionNext #7077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ananas-viber wants to merge 2 commits into from
Closed

fix(permission): trigger permission.ask plugin hook in PermissionNext #7077

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
338610a
fix(permission): trigger permission.ask plugin hook in PermissionNext
Jan 6, 2026
df1fd29
fix: use switch statement for type safety
Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions packages/opencode/src/permission/next.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { BusEvent } from "@/bus/bus-event"
import { Config } from "@/config/config"
import { Identifier } from "@/id/id"
import { Instance } from "@/project/instance"
import { Plugin } from "@/plugin"
import { Storage } from "@/storage/storage"
import { fn } from "@/util/fn"
import { Log } from "@/util/log"
Expand Down Expand Up @@ -127,11 +128,27 @@ export namespace PermissionNext {
throw new DeniedError(ruleset.filter((r) => Wildcard.match(request.permission, r.permission)))
if (rule.action === "ask") {
const id = input.id ?? Identifier.ascending("permission")
const info: Request = {
id,
...request,
}

// Allow plugins to intercept permission requests (fixes #7006)
switch (
await Plugin.trigger("permission.ask", info, {
status: "ask",
}).then((x) => x.status)
) {
case "allow":
log.info("plugin auto-approved", { permission: request.permission, pattern })
continue // Auto-approve
case "deny":
log.info("plugin auto-denied", { permission: request.permission, pattern })
throw new DeniedError(ruleset.filter((r) => Wildcard.match(request.permission, r.permission)))
}

// If hook returns "ask" or unchanged, proceed with UI prompt
return new Promise<void>((resolve, reject) => {
const info: Request = {
id,
...request,
}
s.pending[id] = {
info,
resolve,
Expand Down