fix(desktop): complete symlink support implementation and enable CI for PRs #7107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or PRs Follow-up to anomalyco#7102 which was merged incomplete: - Use tauri::process::current_binary() instead of tauri::utils::platform::current_exe() - Pass AppHandle to get_sidecar_path() to provide required &Env parameter - Update install_cli() and sync_cli() to pass AppHandle through call chain - Enable nix-desktop workflow on pull_request events for same paths as push
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the incomplete symlink support implementation from #7102 by properly threading the AppHandle parameter through the call chain to enable tauri::process::current_binary() API usage, and enables CI validation for pull requests.
- Updates function signatures to accept and pass
AppHandlefor symlink-aware binary path resolution - Fixes build failures by providing the required
&Envparameter totauri::process::current_binary() - Enables the nix-desktop CI workflow for pull request events
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/desktop/src-tauri/src/lib.rs | Updates spawn_sidecar to pass app parameter when calling get_sidecar_path for non-Windows platforms |
| packages/desktop/src-tauri/src/cli.rs | Updates get_sidecar_path to accept AppHandle and use tauri::process::current_binary; updates install_cli to accept and pass AppHandle; updates sync_cli to pass app when calling install_cli |
| .github/workflows/nix-desktop.yml | Adds pull_request trigger with same path filters as push trigger to enable CI validation for PRs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jerome-benoit
force-pushed
the
fix/desktop-symlink-support-complete
branch
3 times, most recently
from
c181704 to
14d0d35
Compare
jerome-benoit
force-pushed
the
fix/desktop-symlink-support-complete
branch
from
14d0d35 to
562df96
Compare
Contributor
Author
|
Closing this PR - it contained unrelated files from branch history. Opening clean PR with only the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7102 which was merged incomplete. Completes the symlink support implementation and enables CI validation for PRs.
Changes
Desktop symlink support:
tauri::process::current_binary()instead oftauri::utils::platform::current_exe()AppHandletoget_sidecar_path()to provide required&Envparameterinstall_cli()andsync_cli()to passAppHandlethrough call chainCI improvements:
nix-desktopworkflow onpull_requestevents with same paths aspushContext
PR #7102 introduced
tauri::process::current_binary()but didn't pass the required&Envparameter, causing build failures. This PR fixes the implementation by properly threading theAppHandlethrough the call chain.