fix: truncate webfetch response to MAX_TOKENS #7166
+108
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
roerohan
commented
Jan 7, 2026
| if (tokenCount > MAX_TOKENS) { | ||
| const charsPerToken = 4 | ||
| const maxChars = MAX_TOKENS * charsPerToken | ||
| output = output.slice(0, maxChars) |
Contributor
Author
There was a problem hiding this comment.
Maybe instead of truncating using slice, I could store the response in a temporary file and the LLM could read that for context as required 🤔
Contributor
Author
There was a problem hiding this comment.
Perhaps something like this?
Contributor
Author
There was a problem hiding this comment.
Added this change in 7223a39, can abandon this commit if you'd rather go with the naive approach.
roerohan
force-pushed
the
webfetch-max-tokens
branch
from
06837f2 to
7223a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://x.com/i/status/2008730842752000460