fix(tui): increase permission dialog height for better code review #7172
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the diff view maxHeight from 1/4 to 1/2 of terminal height, making it easier to review code changes before approving permissions. Fixes anomalyco#7091
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7091
The permission dialog's diff view was limited to 1/4 of the terminal height, making it difficult to review code changes before approving.
Changes
Changed
maxHeightfromMath.floor(dimensions().height / 4)toMath.floor(dimensions().height / 2)inpermission.tsx, doubling the available space for code review.Before/After
This makes it much easier to review larger diffs before approving permission requests.
File Changed
packages/opencode/src/cli/cmd/tui/routes/session/permission.tsx