fix: Add signature field to ReasoningPart #7222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Why they're related: Both PRs address compatibility issues when switching between different models and handling thinking/reasoning blocks. PR #6748 handles stripping incompatible thinking blocks when switching to Anthropic models, while PR #7222 adds signature field support for Claude. These changes may be related to the same issue (#6418) about model compatibility with thinking blocks. |
Contributor
Author
|
Closing as superseded by #6748 which provides a more complete fix - stripping incompatible thinking blocks and converting reasoning to text when switching to Anthropic models. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optional
signaturefield to theReasoningParttype to support thinking block signatures required by models like Claude.Changes
signature: z.string().optional()toReasoningPartinpackages/opencode/src/session/message-v2.tssignature: z.string().optional()toReasoningPartinpackages/opencode/src/session/message.tstoModelMessagefunction to include the signature when converting reasoning partsRelated Issue
Fixes issue #6418: "Error: Invalid signature in thinking block" when switching models from MiniMax/GLM to Claude