fix(grep): follow symlinks by default in ripgrep searches #7501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes anomalyco#7498 - Add --follow flag to grep tool for consistent symlink traversal - Add --hidden flag to grep tool for parity with ripgrep search - Add follow?: boolean parameter to Ripgrep.search() (default: true) for API flexibility while maintaining backward compatibility
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Collaborator
|
/review |
Contributor
|
lgtm |
Contributor
Author
|
TYSM! |
fwang
pushed a commit
to lifefloating/opencode
that referenced
this pull request
Jan 10, 2026
zerone0x
pushed a commit
to zerone0x/opencode
that referenced
this pull request
Jan 12, 2026
zerone0x
pushed a commit
to zerone0x/opencode
that referenced
this pull request
Jan 12, 2026
vtemian
added a commit
to vtemian/opencode
that referenced
this pull request
Jan 12, 2026
Resolve conflicts: - grep.ts: use renamed rg() + add --hidden/--follow flags from anomalyco#7501 - ripgrep.ts: accept deletion, port follow param to ripgrep/index.ts
athal7
pushed a commit
to athal7/opencode
that referenced
this pull request
Jan 13, 2026
liorshk
pushed a commit
to liorshk/opencode
that referenced
this pull request
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7498 - Grep fails on symlinked directories
Changes
--followflag to grep tool for consistent symlink traversal--hiddenflag to grep tool for parity withRipgrep.search()follow?: booleanparameter toRipgrep.search()with defaulttruefor API consistency withRipgrep.files()Design Decision
Following VS Code's approach, symlinks are now followed by default since OpenCode is an IDE-like tool where users expect to find all their code regardless of filesystem structure. The
followparameter provides an escape hatch for users who need stricter behavior.Compliance
files()andsearch()now have consistent API for thefollowparameterfollowparameter explicitly communicates symlink-following behaviorNote for Maintainers
During review, we noticed that
grep.tsdoes not include--glob='!.git/*'whileRipgrep.search()does. This is a pre-existing inconsistency (not related to this PR). If you'd like us to add this for consistency, we're happy to update the PR.