fix(tui): normalize ctrl keybinds on non-latin layouts#7573
Open
artonyuan wants to merge 2 commits intoanomalyco:devfrom
Open
fix(tui): normalize ctrl keybinds on non-latin layouts#7573artonyuan wants to merge 2 commits intoanomalyco:devfrom
artonyuan wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
This PR (#6753) may already have addressed the keybind issue for non-Latin layouts. You should verify if PR #7573 is solving the same problem or if it's a complementary/improved fix specific to the TUI layer. |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When Ctrl/Alt/Cmd is held, the keybind now uses the physical key’s base letter (like “v”) instead of the layout-specific character (like “м”). This makes modified shortcuts like Ctrl+V and Ctrl+P work even when the macOS input source is Russian.
How did you verify your code works?
Ctrl+Vpastes in the TUI input.Ctrl+Popens the command list.Related: #6753. This PR is a small TUI‑only fix that normalizes modified keys without a config toggle.