Skip to content

fix(app): ensure file search query param #8164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnnyapu15 wants to merge 1 commit into from
+16 −7
Closed

fix(app): ensure file search query param #8164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/app/src/context/file.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,10 +384,14 @@ export const { use: useFile, provider: FileProvider } = createSimpleContext({
setScrollLeft,
selectedLines,
setSelectedLines,
searchFiles: (query: string) =>
sdk.client.find.files({ query, dirs: "false" }).then((x) => (x.data ?? []).map(normalize)),
searchFilesAndDirectories: (query: string) =>
sdk.client.find.files({ query, dirs: "true" }).then((x) => (x.data ?? []).map(normalize)),
searchFiles: (query: string | undefined) => {
const safeQuery = query ?? ""
return sdk.client.find.files({ query: safeQuery, dirs: "false" }).then((x) => (x.data ?? []).map(normalize))
},
searchFilesAndDirectories: (query: string | undefined) => {
const safeQuery = query ?? ""
return sdk.client.find.files({ query: safeQuery, dirs: "true" }).then((x) => (x.data ?? []).map(normalize))
},
}
},
})
11 changes: 8 additions & 3 deletions packages/app/src/context/local.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,14 @@ export const { use: useLocal, provider: LocalProvider } = createSimpleContext({
.catch(() => {})
}

const searchFiles = (query: string) => sdk.client.find.files({ query, dirs: "false" }).then((x) => x.data!)
const searchFilesAndDirectories = (query: string) =>
sdk.client.find.files({ query, dirs: "true" }).then((x) => x.data!)
const searchFiles = (query: string | undefined) => {
const safeQuery = query ?? ""
return sdk.client.find.files({ query: safeQuery, dirs: "false" }).then((x) => x.data!)
}
const searchFilesAndDirectories = (query: string | undefined) => {
const safeQuery = query ?? ""
return sdk.client.find.files({ query: safeQuery, dirs: "true" }).then((x) => x.data!)
}

const unsub = sdk.event.listen((e) => {
const event = e.details
Expand Down